Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: components/gcm_driver/gcm_stats_recorder_impl.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/gcm_stats_recorder_impl.cc
diff --git a/components/gcm_driver/gcm_stats_recorder_impl.cc b/components/gcm_driver/gcm_stats_recorder_impl.cc
index 1e40fb58a7ea90c98f9fbcfe13e37dd86f54a666..e1731c707602ff7b9bdc57846152dfe83f9edb5a 100644
--- a/components/gcm_driver/gcm_stats_recorder_impl.cc
+++ b/components/gcm_driver/gcm_stats_recorder_impl.cc
@@ -206,8 +206,8 @@ void GCMStatsRecorderImpl::RecordCheckinSuccess() {
RecordCheckin("Checkin succeeded", std::string());
}
-void GCMStatsRecorderImpl::RecordCheckinFailure(std::string status,
- bool will_retry) {
+void GCMStatsRecorderImpl::RecordCheckinFailure(const std::string& status,
+ bool will_retry) {
if (!is_recording_)
return;
RecordCheckin("Checkin failed", base::StringPrintf(

Powered by Google App Engine
This is Rietveld 408576698