Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: components/gcm_driver/gcm_stats_recorder_impl.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/gcm_stats_recorder_impl.h
diff --git a/components/gcm_driver/gcm_stats_recorder_impl.h b/components/gcm_driver/gcm_stats_recorder_impl.h
index de11d49121b0d84ae4c6746caec45af3e76c4f82..1656bb8536bfaceb762fc4db084ff7bb0ae22ff5 100644
--- a/components/gcm_driver/gcm_stats_recorder_impl.h
+++ b/components/gcm_driver/gcm_stats_recorder_impl.h
@@ -47,7 +47,8 @@ class GCMStatsRecorderImpl : public GCMStatsRecorder {
void RecordCheckinInitiated(uint64 android_id) override;
void RecordCheckinDelayedDueToBackoff(int64 delay_msec) override;
void RecordCheckinSuccess() override;
- void RecordCheckinFailure(std::string status, bool will_retry) override;
+ void RecordCheckinFailure(const std::string& status,
+ bool will_retry) override;
void RecordConnectionInitiated(const std::string& host) override;
void RecordConnectionDelayedDueToBackoff(int64 delay_msec) override;
void RecordConnectionSuccess() override;

Powered by Google App Engine
This is Rietveld 408576698