chromeos/network/network_connection_handler.h - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/network_connection_handler.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chromeos/network/network_connection_handler.h

diff --git a/chromeos/network/network_connection_handler.h b/chromeos/network/network_connection_handler.h

index ddadf7a19e9df118f1cdb13cc07ba1b9847c1cbe..7a62ef12f437518d29d16308c8dc59faaa0c12c4 100644

--- a/chromeos/network/network_connection_handler.h

+++ b/chromeos/network/network_connection_handler.h

@@ -193,7 +193,7 @@ class CHROMEOS_EXPORT NetworkConnectionHandler

const std::string& error_name,

const std::string& error_message);

- void CheckPendingRequest(const std::string service_path);

+ void CheckPendingRequest(const std::string& service_path);

void CheckAllPendingRequests();

// Notify caller and observers that the connect request succeeded.

« no previous file with comments | « chromeos/dbus/fake_shill_manager_client.cc ('k') | chromeos/network/network_connection_handler.cc » ('j') | url/gurl.h » ('J')