Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: chromeos/network/network_connection_handler.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROMEOS_NETWORK_NETWORK_CONNECTION_HANDLER_H_ 5 #ifndef CHROMEOS_NETWORK_NETWORK_CONNECTION_HANDLER_H_
6 #define CHROMEOS_NETWORK_NETWORK_CONNECTION_HANDLER_H_ 6 #define CHROMEOS_NETWORK_NETWORK_CONNECTION_HANDLER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 const std::string& service_path, 186 const std::string& service_path,
187 const std::string& error_name, 187 const std::string& error_name,
188 scoped_ptr<base::DictionaryValue> error_data); 188 scoped_ptr<base::DictionaryValue> error_data);
189 189
190 // Handles success or failure from Shill.Service.Connect. 190 // Handles success or failure from Shill.Service.Connect.
191 void HandleShillConnectSuccess(const std::string& service_path); 191 void HandleShillConnectSuccess(const std::string& service_path);
192 void HandleShillConnectFailure(const std::string& service_path, 192 void HandleShillConnectFailure(const std::string& service_path,
193 const std::string& error_name, 193 const std::string& error_name,
194 const std::string& error_message); 194 const std::string& error_message);
195 195
196 void CheckPendingRequest(const std::string service_path); 196 void CheckPendingRequest(const std::string& service_path);
197 void CheckAllPendingRequests(); 197 void CheckAllPendingRequests();
198 198
199 // Notify caller and observers that the connect request succeeded. 199 // Notify caller and observers that the connect request succeeded.
200 void InvokeConnectSuccessCallback(const std::string& service_path, 200 void InvokeConnectSuccessCallback(const std::string& service_path,
201 const base::Closure& success_callback); 201 const base::Closure& success_callback);
202 202
203 // Look up the ConnectRequest for |service_path| and call 203 // Look up the ConnectRequest for |service_path| and call
204 // InvokeConnectErrorCallback. 204 // InvokeConnectErrorCallback.
205 void ErrorCallbackForPendingRequest(const std::string& service_path, 205 void ErrorCallbackForPendingRequest(const std::string& service_path,
206 const std::string& error_name); 206 const std::string& error_name);
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
239 bool logged_in_; 239 bool logged_in_;
240 bool certificates_loaded_; 240 bool certificates_loaded_;
241 base::TimeTicks logged_in_time_; 241 base::TimeTicks logged_in_time_;
242 242
243 DISALLOW_COPY_AND_ASSIGN(NetworkConnectionHandler); 243 DISALLOW_COPY_AND_ASSIGN(NetworkConnectionHandler);
244 }; 244 };
245 245
246 } // namespace chromeos 246 } // namespace chromeos
247 247
248 #endif // CHROMEOS_NETWORK_NETWORK_CONNECTION_HANDLER_H_ 248 #endif // CHROMEOS_NETWORK_NETWORK_CONNECTION_HANDLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698