Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: chromeos/dbus/fake_shill_manager_client.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/fake_shill_manager_client.cc
diff --git a/chromeos/dbus/fake_shill_manager_client.cc b/chromeos/dbus/fake_shill_manager_client.cc
index 337041b9e489b511827dbd9e8bce3648f02dcdef..c44f7cf8be0840b1392003871a73f2587d14255f 100644
--- a/chromeos/dbus/fake_shill_manager_client.cc
+++ b/chromeos/dbus/fake_shill_manager_client.cc
@@ -1115,8 +1115,9 @@ bool FakeShillManagerClient::ParseOption(const std::string& arg0,
return SetInitialNetworkState(arg0, arg1);
}
-bool FakeShillManagerClient::SetInitialNetworkState(std::string type_arg,
- std::string state_arg) {
+bool FakeShillManagerClient::SetInitialNetworkState(
+ const std::string& type_arg,
+ const std::string& state_arg) {
int state_arg_as_int = -1;
base::StringToInt(state_arg, &state_arg_as_int);

Powered by Google App Engine
This is Rietveld 408576698