chrome/test/chromedriver/chrome/automation_extension.h - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/automation_extension.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/chromedriver/chrome/automation_extension.h

diff --git a/chrome/test/chromedriver/chrome/automation_extension.h b/chrome/test/chromedriver/chrome/automation_extension.h

index c431e5a488251bb52ef023d53ead48bb7534a5b2..6c27a1708074f281bda6353fcf4fed129ddc97b0 100644

--- a/chrome/test/chromedriver/chrome/automation_extension.h

+++ b/chrome/test/chromedriver/chrome/automation_extension.h

@@ -28,7 +28,7 @@ class AutomationExtension {

Status CaptureScreenshot(std::string* screenshot);

// Launches an app with the specified id.

- Status LaunchApp(std::string id);

+ Status LaunchApp(const std::string& id);

// Gets the position of the current window.

Status GetWindowPosition(int* x, int* y);

« no previous file with comments | « chrome/test/chromedriver/capabilities.cc ('k') | chrome/test/chromedriver/chrome/automation_extension.cc » ('j') | url/gurl.h » ('J')