Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4817)

Unified Diff: chrome/test/chromedriver/capabilities.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/capabilities.cc
diff --git a/chrome/test/chromedriver/capabilities.cc b/chrome/test/chromedriver/capabilities.cc
index e4ba8638bc6fb7b7e5f0c2273645ad6c28a4c047..bec8f64de9247c7d5d0663b7c78486f9b67359ee 100644
--- a/chrome/test/chromedriver/capabilities.cc
+++ b/chrome/test/chromedriver/capabilities.cc
@@ -97,7 +97,8 @@ Status ParseLogPath(const base::Value& option, Capabilities* capabilities) {
return Status(kOk);
}
-Status ParseDeviceName(std::string device_name, Capabilities* capabilities) {
+Status ParseDeviceName(const std::string& device_name,
+ Capabilities* capabilities) {
scoped_ptr<MobileDevice> device;
Status status = FindMobileDevice(device_name, &device);

Powered by Google App Engine
This is Rietveld 408576698