Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: chrome/test/chromedriver/chrome/automation_extension.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/automation_extension.cc
diff --git a/chrome/test/chromedriver/chrome/automation_extension.cc b/chrome/test/chromedriver/chrome/automation_extension.cc
index 2aa4d22a0ae1d945e50d3f0599ded5fc0e482f68..555f9e9e5dccce2473e0bc5341eca22c24cf01dc 100644
--- a/chrome/test/chromedriver/chrome/automation_extension.cc
+++ b/chrome/test/chromedriver/chrome/automation_extension.cc
@@ -107,7 +107,7 @@ Status AutomationExtension::UpdateWindow(
&result);
}
-Status AutomationExtension::LaunchApp(std::string id) {
+Status AutomationExtension::LaunchApp(const std::string& id) {
base::ListValue args;
args.AppendString(id);
scoped_ptr<base::Value> result;

Powered by Google App Engine
This is Rietveld 408576698