Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3134)

Unified Diff: chrome/renderer/searchbox/searchbox_extension.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/searchbox/searchbox_extension.cc
diff --git a/chrome/renderer/searchbox/searchbox_extension.cc b/chrome/renderer/searchbox/searchbox_extension.cc
index 0113c712d1d45f194874078d51d3f5d5dece3b8a..5ff90824b7f1d4cafc606f35151b53875dd2a401 100644
--- a/chrome/renderer/searchbox/searchbox_extension.cc
+++ b/chrome/renderer/searchbox/searchbox_extension.cc
@@ -117,7 +117,8 @@ v8::Local<v8::String> GenerateThumbnailURL(
"chrome-search://thumb/%d/%d", render_view_id, most_visited_item_id));
}
-v8::Local<v8::String> GenerateThumb2URL(v8::Isolate* isolate, std::string url) {
+v8::Local<v8::String> GenerateThumb2URL(v8::Isolate* isolate,
+ const std::string& url) {
return UTF8ToV8String(
isolate, base::StringPrintf("chrome-search://thumb2/%s", url.c_str()));
}

Powered by Google App Engine
This is Rietveld 408576698