Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9749)

Unified Diff: chrome/common/icon_with_badge_image_source.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/icon_with_badge_image_source.cc
diff --git a/chrome/common/icon_with_badge_image_source.cc b/chrome/common/icon_with_badge_image_source.cc
index 1afdbeee9830d53db8b3d4f8cb0e881b1c8afe37..b1cad82f56448892c42f4d5ed0396ebc02826e75 100644
--- a/chrome/common/icon_with_badge_image_source.cc
+++ b/chrome/common/icon_with_badge_image_source.cc
@@ -11,11 +11,10 @@
#include "ui/gfx/geometry/rect.h"
#include "ui/gfx/image/image_skia_operations.h"
-IconWithBadgeImageSource::Badge::Badge(std::string text,
+IconWithBadgeImageSource::Badge::Badge(const std::string& text,
SkColor text_color,
SkColor background_color)
- : text(text), text_color(text_color), background_color(background_color) {
-}
+ : text(text), text_color(text_color), background_color(background_color) {}
IconWithBadgeImageSource::Badge::~Badge() {}

Powered by Google App Engine
This is Rietveld 408576698