Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6236)

Unified Diff: chrome/common/icon_with_badge_image_source.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/icon_with_badge_image_source.h
diff --git a/chrome/common/icon_with_badge_image_source.h b/chrome/common/icon_with_badge_image_source.h
index 3270ce3244dd5095f35c2f74c3f51a8d347d4c82..77331fbf673e7bcfaaf6348d509934a5a84461eb 100644
--- a/chrome/common/icon_with_badge_image_source.h
+++ b/chrome/common/icon_with_badge_image_source.h
@@ -22,7 +22,9 @@ class IconWithBadgeImageSource : public gfx::CanvasImageSource {
public:
// The data representing a badge to be painted over the base image.
struct Badge {
- Badge(std::string text, SkColor text_color, SkColor background_color);
+ Badge(const std::string& text,
+ SkColor text_color,
+ SkColor background_color);
~Badge();
std::string text;

Powered by Google App Engine
This is Rietveld 408576698