chrome/browser/ui/website_settings/website_settings_unittest.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/website_settings/website_settings_unittest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc ('k') | chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.h » ('j') | url/gurl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/website_settings/website_settings_unittest.cc

diff --git a/chrome/browser/ui/website_settings/website_settings_unittest.cc b/chrome/browser/ui/website_settings/website_settings_unittest.cc

index 5eaba491ce31ac944c31461d0fd2cdbbd49fb6a7..16b6ba0f774f2f0977edb559834631114c225616 100644

--- a/chrome/browser/ui/website_settings/website_settings_unittest.cc

+++ b/chrome/browser/ui/website_settings/website_settings_unittest.cc

@@ -117,7 +117,7 @@ class WebsiteSettingsTest : public ChromeRenderViewHostTestHarness {

EXPECT_CALL(*mock_ui, SetCookieInfo(_));

}

- void SetURL(std::string url) { url_ = GURL(url); }

+ void SetURL(const std::string& url) { url_ = GURL(url); }

const GURL& url() const { return url_; }

MockCertStore* cert_store() { return &cert_store_; }