chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.h - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/website_settings/website_settings_unittest.cc ('k') | chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.cc » ('j') | url/gurl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.h

diff --git a/chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.h b/chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.h

index 9fa8864301a492c4c10fb706bb8e31dec5da76ad..0a970967b8786ff13175cd639397fe000e352dab 100644

--- a/chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.h

+++ b/chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.h

@@ -49,7 +49,8 @@ class NewTabPageSyncHandler : public content::WebUIMessageHandler,

};

// Helper to invoke the |syncMessageChanged| JS function on the new tab page.

virtual void SendSyncMessageToPage(MessageType type,

- std::string msg, std::string linktext);

+ const std::string& msg,

+ const std::string& linktext);

// Helper to query the sync service and figure out what to send to

// the page, and send it via SendSyncMessageToPage.

« no previous file with comments | « chrome/browser/ui/website_settings/website_settings_unittest.cc ('k') | chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.cc » ('j') | url/gurl.h » ('J')