chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc

diff --git a/chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc b/chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc

index acfdadb606f73f3e3f9d66d5450d8c5cf7eaacd2..6b6e035c71d6c4dcf5c9a2541a3aad1c5b0ef7a8 100644

--- a/chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc

+++ b/chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc

@@ -46,7 +46,7 @@ class WebNotificationTrayTest : public InProcessBrowserTest {

protected:

class TestNotificationDelegate : public ::NotificationDelegate {

public:

- explicit TestNotificationDelegate(std::string id) : id_(id) {}

+ explicit TestNotificationDelegate(const std::string& id) : id_(id) {}

std::string id() const override { return id_; }

private:

« no previous file with comments | « chrome/browser/ui/toolbar/toolbar_actions_model.h ('k') | chrome/browser/ui/website_settings/website_settings_unittest.cc » ('j') | url/gurl.h » ('J')