chrome/browser/ui/toolbar/toolbar_actions_model.h - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/toolbar_actions_model.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/profiles/user_manager_mac.mm ('k') | chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc » ('j') | url/gurl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/toolbar/toolbar_actions_model.h

diff --git a/chrome/browser/ui/toolbar/toolbar_actions_model.h b/chrome/browser/ui/toolbar/toolbar_actions_model.h

index a92068cfb4e12f78d5a67b5d6baf08c707fc133d..ebeaeeee92605aaf2789c12eb7bcbd3200de5b0f 100644

--- a/chrome/browser/ui/toolbar/toolbar_actions_model.h

+++ b/chrome/browser/ui/toolbar/toolbar_actions_model.h

@@ -56,7 +56,7 @@ class ToolbarActionsModel : public extensions::ExtensionActionAPI::Observer,

// An action id and its corresponding ActionType.

struct ToolbarItem {

ToolbarItem() : type(UNKNOWN_ACTION) {}

- ToolbarItem(std::string action_id, ActionType action_type)

+ ToolbarItem(const std::string& action_id, ActionType action_type)

: id(action_id), type(action_type) {}

bool operator==(const ToolbarItem& other) { return other.id == id; }