chrome/browser/ui/ash/launcher/chrome_launcher_controller.h - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller.h

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h b/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h

index 7cdf3a3d2a2a3a2994a31db246fc76491211223b..499b3786b6cb0552d1c6d96e1de63838d66ba1e4 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h

@@ -352,7 +352,7 @@ class ChromeLauncherController

// Get the list of all tabs which belong to a certain application type.

std::vector<content::WebContents*> GetV1ApplicationsFromAppId(

- std::string app_id);

+ const std::string& app_id);

// Activates a specified shell application.

void ActivateShellApp(const std::string& app_id, int index);

« no previous file with comments | « chrome/browser/tracing/crash_service_uploader.cc ('k') | chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc » ('j') | url/gurl.h » ('J')