Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Side by Side Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_CONTROLLER_H_
6 #define CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_CONTROLLER_H_ 6 #define CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_CONTROLLER_H_
7 7
8 #include <list> 8 #include <list>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 334 matching lines...) Expand 10 before | Expand all | Expand 10 after
345 void AdditionalUserAddedToSession(Profile* profile); 345 void AdditionalUserAddedToSession(Profile* profile);
346 346
347 // Get the list of all running incarnations of this item. 347 // Get the list of all running incarnations of this item.
348 // |event_flags| specifies the flags which were set by the event which 348 // |event_flags| specifies the flags which were set by the event which
349 // triggered this menu generation. It can be used to generate different lists. 349 // triggered this menu generation. It can be used to generate different lists.
350 ChromeLauncherAppMenuItems GetApplicationList(const ash::ShelfItem& item, 350 ChromeLauncherAppMenuItems GetApplicationList(const ash::ShelfItem& item,
351 int event_flags); 351 int event_flags);
352 352
353 // Get the list of all tabs which belong to a certain application type. 353 // Get the list of all tabs which belong to a certain application type.
354 std::vector<content::WebContents*> GetV1ApplicationsFromAppId( 354 std::vector<content::WebContents*> GetV1ApplicationsFromAppId(
355 std::string app_id); 355 const std::string& app_id);
356 356
357 // Activates a specified shell application. 357 // Activates a specified shell application.
358 void ActivateShellApp(const std::string& app_id, int index); 358 void ActivateShellApp(const std::string& app_id, int index);
359 359
360 // Checks if a given |web_contents| is known to be associated with an 360 // Checks if a given |web_contents| is known to be associated with an
361 // application of type |app_id|. 361 // application of type |app_id|.
362 bool IsWebContentHandledByApplication(content::WebContents* web_contents, 362 bool IsWebContentHandledByApplication(content::WebContents* web_contents,
363 const std::string& app_id); 363 const std::string& app_id);
364 364
365 // Check if the gMail app is loaded and it can handle the given web content. 365 // Check if the gMail app is loaded and it can handle the given web content.
(...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after
601 // The list of running & un-pinned applications for different users on hidden 601 // The list of running & un-pinned applications for different users on hidden
602 // desktops. 602 // desktops.
603 typedef std::vector<std::string> RunningAppListIds; 603 typedef std::vector<std::string> RunningAppListIds;
604 typedef std::map<std::string, RunningAppListIds> RunningAppListIdMap; 604 typedef std::map<std::string, RunningAppListIds> RunningAppListIdMap;
605 RunningAppListIdMap last_used_running_application_order_; 605 RunningAppListIdMap last_used_running_application_order_;
606 606
607 DISALLOW_COPY_AND_ASSIGN(ChromeLauncherController); 607 DISALLOW_COPY_AND_ASSIGN(ChromeLauncherController);
608 }; 608 };
609 609
610 #endif // CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_CONTROLLER_H_ 610 #endif // CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698