chrome/browser/spellchecker/spellcheck_service.h - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/spellcheck_service.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/spellchecker/spellcheck_service.h

diff --git a/chrome/browser/spellchecker/spellcheck_service.h b/chrome/browser/spellchecker/spellcheck_service.h

index 81956f8e91160fa38de86c19b976c8558e57f993..9382ca3142d504e31071f10c6821597fad9b1c6d 100644

--- a/chrome/browser/spellchecker/spellcheck_service.h

+++ b/chrome/browser/spellchecker/spellcheck_service.h

@@ -111,7 +111,7 @@ class SpellcheckService : public KeyedService,

// Unload a dictionary. The path is given to identify the dictionary.

// Return value is true if successful.

- bool UnloadExternalDictionary(std::string path);

+ bool UnloadExternalDictionary(const std::string& /* path */);

// NotificationProfile implementation.

void Observe(int type,

« no previous file with comments | « chrome/browser/speech/tts_controller_impl.cc ('k') | chrome/browser/spellchecker/spellcheck_service.cc » ('j') | url/gurl.h » ('J')