chrome/browser/spellchecker/spellcheck_service.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/spellcheck_service.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/spellchecker/spellcheck_service.cc

diff --git a/chrome/browser/spellchecker/spellcheck_service.cc b/chrome/browser/spellchecker/spellcheck_service.cc

index 1cebb74f35279febbd3c1fbbfed1410acffea1df..deca10bfeb9be7c59df269b8d0b2e9ef88375a5f 100644

--- a/chrome/browser/spellchecker/spellcheck_service.cc

+++ b/chrome/browser/spellchecker/spellcheck_service.cc

@@ -230,7 +230,8 @@ bool SpellcheckService::LoadExternalDictionary(std::string language,

return false;

}

-bool SpellcheckService::UnloadExternalDictionary(std::string path) {

+bool SpellcheckService::UnloadExternalDictionary(

+ const std::string& /* path */) {

return false;

}

« no previous file with comments | « chrome/browser/spellchecker/spellcheck_service.h ('k') | chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc » ('j') | url/gurl.h » ('J')