Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Side by Side Diff: chrome/browser/spellchecker/spellcheck_service.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_SERVICE_H_ 5 #ifndef CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_SERVICE_H_
6 #define CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_SERVICE_H_ 6 #define CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_SERVICE_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 104
105 // Load a dictionary from a given path. Format specifies how the dictionary 105 // Load a dictionary from a given path. Format specifies how the dictionary
106 // is stored. Return value is true if successful. 106 // is stored. Return value is true if successful.
107 bool LoadExternalDictionary(std::string language, 107 bool LoadExternalDictionary(std::string language,
108 std::string locale, 108 std::string locale,
109 std::string path, 109 std::string path,
110 DictionaryFormat format); 110 DictionaryFormat format);
111 111
112 // Unload a dictionary. The path is given to identify the dictionary. 112 // Unload a dictionary. The path is given to identify the dictionary.
113 // Return value is true if successful. 113 // Return value is true if successful.
114 bool UnloadExternalDictionary(std::string path); 114 bool UnloadExternalDictionary(const std::string& /* path */);
115 115
116 // NotificationProfile implementation. 116 // NotificationProfile implementation.
117 void Observe(int type, 117 void Observe(int type,
118 const content::NotificationSource& source, 118 const content::NotificationSource& source,
119 const content::NotificationDetails& details) override; 119 const content::NotificationDetails& details) override;
120 120
121 // SpellcheckCustomDictionary::Observer implementation. 121 // SpellcheckCustomDictionary::Observer implementation.
122 void OnCustomDictionaryLoaded() override; 122 void OnCustomDictionaryLoaded() override;
123 void OnCustomDictionaryChanged( 123 void OnCustomDictionaryChanged(
124 const SpellcheckCustomDictionary::Change& dictionary_change) override; 124 const SpellcheckCustomDictionary::Change& dictionary_change) override;
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 ScopedVector<SpellcheckHunspellDictionary> hunspell_dictionaries_; 171 ScopedVector<SpellcheckHunspellDictionary> hunspell_dictionaries_;
172 172
173 scoped_ptr<spellcheck::FeedbackSender> feedback_sender_; 173 scoped_ptr<spellcheck::FeedbackSender> feedback_sender_;
174 174
175 base::WeakPtrFactory<SpellcheckService> weak_ptr_factory_; 175 base::WeakPtrFactory<SpellcheckService> weak_ptr_factory_;
176 176
177 DISALLOW_COPY_AND_ASSIGN(SpellcheckService); 177 DISALLOW_COPY_AND_ASSIGN(SpellcheckService);
178 }; 178 };
179 179
180 #endif // CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_SERVICE_H_ 180 #endif // CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_SERVICE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698