Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Side by Side Diff: chrome/browser/spellchecker/spellcheck_service.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/spellchecker/spellcheck_service.h" 5 #include "chrome/browser/spellchecker/spellcheck_service.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/prefs/pref_member.h" 8 #include "base/prefs/pref_member.h"
9 #include "base/prefs/pref_service.h" 9 #include "base/prefs/pref_service.h"
10 #include "base/strings/string_split.h" 10 #include "base/strings/string_split.h"
(...skipping 212 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 return feedback_sender_.get(); 223 return feedback_sender_.get();
224 } 224 }
225 225
226 bool SpellcheckService::LoadExternalDictionary(std::string language, 226 bool SpellcheckService::LoadExternalDictionary(std::string language,
227 std::string locale, 227 std::string locale,
228 std::string path, 228 std::string path,
229 DictionaryFormat format) { 229 DictionaryFormat format) {
230 return false; 230 return false;
231 } 231 }
232 232
233 bool SpellcheckService::UnloadExternalDictionary(std::string path) { 233 bool SpellcheckService::UnloadExternalDictionary(
234 const std::string& /* path */) {
234 return false; 235 return false;
235 } 236 }
236 237
237 void SpellcheckService::Observe(int type, 238 void SpellcheckService::Observe(int type,
238 const content::NotificationSource& source, 239 const content::NotificationSource& source,
239 const content::NotificationDetails& details) { 240 const content::NotificationDetails& details) {
240 DCHECK(type == content::NOTIFICATION_RENDERER_PROCESS_CREATED); 241 DCHECK(type == content::NOTIFICATION_RENDERER_PROCESS_CREATED);
241 content::RenderProcessHost* process = 242 content::RenderProcessHost* process =
242 content::Source<content::RenderProcessHost>(source).ptr(); 243 content::Source<content::RenderProcessHost>(source).ptr();
243 InitForRenderer(process); 244 InitForRenderer(process);
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
349 } 350 }
350 351
351 void SpellcheckService::UpdateFeedbackSenderState() { 352 void SpellcheckService::UpdateFeedbackSenderState() {
352 if (SpellingServiceClient::IsAvailable( 353 if (SpellingServiceClient::IsAvailable(
353 context_, SpellingServiceClient::SPELLCHECK)) { 354 context_, SpellingServiceClient::SPELLCHECK)) {
354 feedback_sender_->StartFeedbackCollection(); 355 feedback_sender_->StartFeedbackCollection();
355 } else { 356 } else {
356 feedback_sender_->StopFeedbackCollection(); 357 feedback_sender_->StopFeedbackCollection();
357 } 358 }
358 } 359 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698