chrome/browser/local_discovery/privet_url_fetcher_unittest.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/local_discovery/privet_url_fetcher_unittest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/local_discovery/privet_url_fetcher_unittest.cc

diff --git a/chrome/browser/local_discovery/privet_url_fetcher_unittest.cc b/chrome/browser/local_discovery/privet_url_fetcher_unittest.cc

index 75dd5fcbc657c38fcb3167441c84796f89f7315b..c2940aa6442bf6bbc52ddbbe3ee522938038fab7 100644

--- a/chrome/browser/local_discovery/privet_url_fetcher_unittest.cc

+++ b/chrome/browser/local_discovery/privet_url_fetcher_unittest.cc

@@ -71,7 +71,7 @@ class MockPrivetURLFetcherDelegate : public PrivetURLFetcher::Delegate {

return true;

}

- MOCK_METHOD1(OnRawDataInternal, void(std::string data));

+ MOCK_METHOD1(OnRawDataInternal, void(const std::string& data));

MOCK_METHOD0(OnFileInternal, void());

« no previous file with comments | « chrome/browser/external_extension_browsertest.cc ('k') | chrome/browser/logging_chrome_unittest.cc » ('j') | url/gurl.h » ('J')