Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2170)

Unified Diff: chrome/browser/logging_chrome_unittest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/logging_chrome_unittest.cc
diff --git a/chrome/browser/logging_chrome_unittest.cc b/chrome/browser/logging_chrome_unittest.cc
index d6d79b6139d21b4962e0c2770eaced9b519c213e..dcc0dce793bf13a52a95e65224be57e46064d413 100644
--- a/chrome/browser/logging_chrome_unittest.cc
+++ b/chrome/browser/logging_chrome_unittest.cc
@@ -13,7 +13,7 @@ class ChromeLoggingTest : public testing::Test {
public:
// Stores the current value of the log file name environment
// variable and sets the variable to new_value.
- void SaveEnvironmentVariable(std::string new_value) {
+ void SaveEnvironmentVariable(const std::string& new_value) {
scoped_ptr<base::Environment> env(base::Environment::Create());
if (!env->GetVar(env_vars::kLogFileName, &environment_filename_))
environment_filename_ = "";

Powered by Google App Engine
This is Rietveld 408576698