Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: chrome/browser/external_extension_browsertest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/external_extension_browsertest.cc
diff --git a/chrome/browser/external_extension_browsertest.cc b/chrome/browser/external_extension_browsertest.cc
index 8b05ec5c593973426b72823127fadebebe7ef391..5a0022c8f1d4e16940ad3d730fe0d50005de607b 100644
--- a/chrome/browser/external_extension_browsertest.cc
+++ b/chrome/browser/external_extension_browsertest.cc
@@ -23,9 +23,10 @@ namespace {
struct IsSearchProviderTestData {
IsSearchProviderTestData() : tab(NULL) {}
- IsSearchProviderTestData(content::WebContents* t, std::string h, GURL url)
- : tab(t), host(h), test_url(url) {
- }
+ IsSearchProviderTestData(content::WebContents* t,
+ const std::string& h,
+ GURL url)
+ : tab(t), host(h), test_url(url) {}
content::WebContents* tab;
std::string host;

Powered by Google App Engine
This is Rietveld 408576698