Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3318)

Unified Diff: chrome/browser/chromeos/settings/device_oauth2_token_service_unittest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/settings/device_oauth2_token_service_unittest.cc
diff --git a/chrome/browser/chromeos/settings/device_oauth2_token_service_unittest.cc b/chrome/browser/chromeos/settings/device_oauth2_token_service_unittest.cc
index 66cde13725274a86efeb8c8e4445f2061f40cd1a..8460758880b8d22cf7c9cb505ed5bae42c0ea51b 100644
--- a/chrome/browser/chromeos/settings/device_oauth2_token_service_unittest.cc
+++ b/chrome/browser/chromeos/settings/device_oauth2_token_service_unittest.cc
@@ -145,7 +145,7 @@ class DeviceOAuth2TokenServiceTest : public testing::Test {
new base::StringValue(refresh_token));
}
- std::string GetValidTokenInfoResponse(const std::string email) {
+ std::string GetValidTokenInfoResponse(const std::string& email) {
return "{ \"email\": \"" + email + "\","
" \"user_id\": \"1234567890\" }";
}

Powered by Google App Engine
This is Rietveld 408576698