Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: chrome/browser/chromeos/preferences_unittest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/preferences_unittest.cc
diff --git a/chrome/browser/chromeos/preferences_unittest.cc b/chrome/browser/chromeos/preferences_unittest.cc
index 27af98328f81dc181ab69f327368cbda22a7c264..3875cb37a1646518d777ff67bf50c34483576f6d 100644
--- a/chrome/browser/chromeos/preferences_unittest.cc
+++ b/chrome/browser/chromeos/preferences_unittest.cc
@@ -339,7 +339,7 @@ class InputMethodPreferencesTest : public PreferencesTest {
}
// Translates engine IDs in a CSV string to input method IDs.
- std::string ToInputMethodIds(std::string value) {
+ std::string ToInputMethodIds(const std::string& value) {
std::vector<std::string> tokens = base::SplitString(
value, ",", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
std::transform(tokens.begin(), tokens.end(), tokens.begin(),

Powered by Google App Engine
This is Rietveld 408576698