Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3584)

Unified Diff: chrome/browser/devtools/devtools_network_controller_unittest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_network_controller_unittest.cc
diff --git a/chrome/browser/devtools/devtools_network_controller_unittest.cc b/chrome/browser/devtools/devtools_network_controller_unittest.cc
index 6893b3ec173951ecd20abd5b173e161eacbab469..ee6684e633456d24f38786bb2506ca0bc83dac1d 100644
--- a/chrome/browser/devtools/devtools_network_controller_unittest.cc
+++ b/chrome/browser/devtools/devtools_network_controller_unittest.cc
@@ -68,7 +68,7 @@ class DevToolsNetworkControllerHelper {
return request_.get();
}
- void SetNetworkState(const std::string id, bool offline) {
+ void SetNetworkState(const std::string& id, bool offline) {
scoped_ptr<DevToolsNetworkConditions> conditions(
new DevToolsNetworkConditions(offline));
controller_.SetNetworkState(id, conditions.Pass());

Powered by Google App Engine
This is Rietveld 408576698