Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1347663003: Revert of telemetry: Add a page set for blink's memory usage measurement (Closed)

Created:
5 years, 3 months ago by Zhen Wang
Modified:
5 years, 2 months ago
CC:
chromium-reviews, haraken, ssid, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of telemetry: Add a page set for blink's memory usage measurement (patchset #18 id:380001 of https://codereview.chromium.org/1266833004/ ) Reason for revert: memory.memory_health_plan failure on chromium.perf Linux/Mac/Win bots See https://code.google.com/p/chromium/issues/detail?id=532075 Original issue's description: > telemetry: Add a page set for blink's memory usage measurement > > The page set will be used as metrics for tracking memory > reduction efforts on Blink. Details can be found at [1]. > > [1] https://docs.google.com/document/d/1zlGQkwkWEu5LUg-CrZHHRuhDtZcuvrRv8bjdC8-noaU/edit?usp=sharing > > BUG=524338 > > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect > > Committed: https://crrev.com/0836ebab5ec66a9092722acacdbacc15b02b18ce > Cr-Commit-Position: refs/heads/master@{#348864} TBR=perezju@chromium.org,hajimehoshi@chromium.org,nednguyen@google.com,petrcermak@chromium.org,primiano@chromium.org,skyostil@chromium.org,bashi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=524338 Committed: https://crrev.com/61473901d6d9ec189aab01ef711d9d378705e9ef Cr-Commit-Position: refs/heads/master@{#348891}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -229 lines) Patch
M tools/perf/benchmarks/benchmark_smoke_unittest.py View 1 chunk +0 lines, -4 lines 0 comments Download
D tools/perf/benchmarks/memory_benchmark.py View 1 chunk +0 lines, -72 lines 0 comments Download
A tools/perf/benchmarks/memory_health_plan.py View 1 chunk +43 lines, -0 lines 0 comments Download
D tools/perf/page_sets/blink_memory_mobile.py View 1 chunk +0 lines, -136 lines 0 comments Download
D tools/perf/page_sets/data/blink_memory_mobile.json View 1 chunk +0 lines, -16 lines 0 comments Download
D tools/perf/page_sets/data/blink_memory_mobile_000.wpr.sha1 View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Zhen Wang
Created Revert of telemetry: Add a page set for blink's memory usage measurement
5 years, 3 months ago (2015-09-15 15:29:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347663003/1
5 years, 3 months ago (2015-09-15 15:30:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 15:30:54 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/61473901d6d9ec189aab01ef711d9d378705e9ef Cr-Commit-Position: refs/heads/master@{#348891}
5 years, 3 months ago (2015-09-15 15:31:49 UTC) #4
commit-bot: I haz the power
5 years, 2 months ago (2015-09-23 12:45:12 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/61473901d6d9ec189aab01ef711d9d378705e9ef
Cr-Commit-Position: refs/heads/master@{#348891}

Powered by Google App Engine
This is Rietveld 408576698