Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2208)

Unified Diff: tools/perf/benchmarks/memory_benchmark.py

Issue 1347663003: Revert of telemetry: Add a page set for blink's memory usage measurement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/benchmark_smoke_unittest.py ('k') | tools/perf/benchmarks/memory_health_plan.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/memory_benchmark.py
diff --git a/tools/perf/benchmarks/memory_benchmark.py b/tools/perf/benchmarks/memory_benchmark.py
deleted file mode 100644
index 163f496ef8c894d6ed365e017ac9e7dee2a84abc..0000000000000000000000000000000000000000
--- a/tools/perf/benchmarks/memory_benchmark.py
+++ /dev/null
@@ -1,72 +0,0 @@
-# Copyright 2015 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-import re
-
-from core import perf_benchmark
-
-from telemetry.timeline import tracing_category_filter
-from telemetry.web_perf import timeline_based_measurement
-
-import page_sets
-
-
-class _MemoryBenchmark(perf_benchmark.PerfBenchmark):
- """Base class for timeline based memory benchmarks."""
-
- def SetExtraBrowserOptions(self, options):
- # TODO(perezju): Temporary workaround to disable periodic memory dumps.
- # See: http://crbug.com/513692
- options.AppendExtraBrowserArgs('--enable-memory-benchmarking')
-
- def CreateTimelineBasedMeasurementOptions(self):
- # Enable only memory-infra, to get memory dumps, and blink.console, to get
- # the timeline markers used for mapping threads to tabs.
- trace_memory = tracing_category_filter.TracingCategoryFilter(
- filter_string='-*,blink.console,disabled-by-default-memory-infra')
- return timeline_based_measurement.Options(overhead_level=trace_memory)
-
-
-class MemoryHealthPlan(_MemoryBenchmark):
- """Timeline based benchmark for the Memory Health Plan."""
-
- _RE_BENCHMARK_VALUES = re.compile('(fore|back)ground-memory_')
-
- page_set = page_sets.MemoryHealthStory
-
- @classmethod
- def Name(cls):
- return 'memory.memory_health_plan'
-
- @classmethod
- def ValueCanBeAddedPredicate(cls, value, is_first_result):
- return bool(cls._RE_BENCHMARK_VALUES.match(value.name))
-
-
-class RendererMemoryBlinkMemoryMobile(_MemoryBenchmark):
- """Timeline based benchmark for measuring memory consumption on mobile
- sites on which blink's memory consumption is relatively high."""
-
- _RE_RENDERER_VALUES = re.compile('.+-memory_.+_renderer')
-
- page_set = page_sets.BlinkMemoryMobilePageSet
-
- def SetExtraBrowserOptions(self, options):
- super(RendererMemoryBlinkMemoryMobile, self).SetExtraBrowserOptions(
- options)
- options.AppendExtraBrowserArgs([
- # TODO(bashi): Temporary workaround for http://crbug.com/461788
- '--no-sandbox',
- # Ignore certs errors because record_wpr cannot handle certs correctly
- # in some cases (e.g. WordPress).
- '--ignore-certificate-errors',
- ])
-
- @classmethod
- def Name(cls):
- return 'memory.blink_memory_mobile'
-
- @classmethod
- def ValueCanBeAddedPredicate(cls, value, is_first_result):
- return bool(cls._RE_RENDERER_VALUES.match(value.name))
« no previous file with comments | « tools/perf/benchmarks/benchmark_smoke_unittest.py ('k') | tools/perf/benchmarks/memory_health_plan.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698