Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1347283005: refactor ContributionSorter to use new API (Closed)

Created:
5 years, 3 months ago by danrubel
Modified:
5 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

refactor ContributionSorter to use new API move CompletionTarget to public API modify DartCompletionRequest to return completion target R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/d6051a53a0d71f63a34e46b439148e8ba5726238

Patch Set 1 #

Total comments: 2

Patch Set 2 : merge #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -378 lines) Patch
M pkg/analysis_server/lib/completion/completion_dart.dart View 2 chunks +2 lines, -1 line 0 comments Download
A + pkg/analysis_server/lib/completion/dart/completion_target.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/common_usage_computer.dart View 5 chunks +12 lines, -8 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/completion_dart.dart View 2 chunks +8 lines, -1 line 0 comments Download
D pkg/analysis_server/lib/src/services/completion/completion_target.dart View 1 chunk +0 lines, -356 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/contribution_sorter.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart View 1 4 chunks +8 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/optype.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 3 chunks +6 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_target_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/optype_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
danrubel
This follows https://codereview.chromium.org/1338173002/ to update ContributionSorter to use the new completion API
5 years, 3 months ago (2015-09-18 12:20:47 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/1347283005/diff/1/pkg/analysis_server/lib/completion/dart/completion_target.dart File pkg/analysis_server/lib/completion/dart/completion_target.dart (right): https://codereview.chromium.org/1347283005/diff/1/pkg/analysis_server/lib/completion/dart/completion_target.dart#newcode97 pkg/analysis_server/lib/completion/dart/completion_target.dart:97: final Object entity; I'm not thrilled with needing ...
5 years, 3 months ago (2015-09-18 18:59:30 UTC) #3
danrubel
Committed patchset #3 (id:40001) manually as d6051a53a0d71f63a34e46b439148e8ba5726238 (presubmit successful).
5 years, 3 months ago (2015-09-18 20:03:27 UTC) #4
danrubel
5 years, 3 months ago (2015-09-18 20:03:51 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1347283005/diff/1/pkg/analysis_server/lib/com...
File pkg/analysis_server/lib/completion/dart/completion_target.dart (right):

https://codereview.chromium.org/1347283005/diff/1/pkg/analysis_server/lib/com...
pkg/analysis_server/lib/completion/dart/completion_target.dart:97: final Object
entity;
On 2015/09/18 18:59:29, Brian Wilkerson wrote:
> I'm not thrilled with needing to use Object, but I don't know of a better
> solution.

A new marker interface implemented by both AstNode and Token ? I'll commit with
it the way it is and we can change it in the next couple days if we come up with
something better than Object.

Powered by Google App Engine
This is Rietveld 408576698