pkg/analysis_server/lib/src/services/completion/contribution_sorter.dart - Issue 1347283005: refactor ContributionSorter to use new API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/contribution_sorter.dart

Issue 1347283005: refactor ContributionSorter to use new API (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: merge Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/completion_target.dart ('k') | pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/contribution_sorter.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/contribution_sorter.dart b/pkg/analysis_server/lib/src/services/completion/contribution_sorter.dart

index a702f66921c5bcd014674e0e55e65852fd83618b..737a837827034da88550c499ea2c8707fa40dda1 100644

--- a/pkg/analysis_server/lib/src/services/completion/contribution_sorter.dart

+++ b/pkg/analysis_server/lib/src/services/completion/contribution_sorter.dart

@@ -4,8 +4,8 @@

library services.completion.sorter;

+import 'package:analysis_server/completion/completion_dart.dart';

import 'package:analysis_server/src/protocol.dart';

-import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';

/**

* The abstract class `ContributionSorter` defines the behavior of objects

@@ -21,5 +21,6 @@ abstract class ContributionSorter {

* in the given completion context may not be resolved.

* This method should execute quickly and not block.

- void sort(DartCompletionRequest request);

+ void sort(DartCompletionRequest request,

+ Iterable<CompletionSuggestion> suggestions);

}