Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: pkg/analysis_server/lib/completion/dart/completion_target.dart

Issue 1347283005: refactor ContributionSorter to use new API (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: merge Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 import 'package:analyzer/src/generated/ast.dart'; 1 import 'package:analyzer/src/generated/ast.dart';
2 import 'package:analyzer/src/generated/element.dart'; 2 import 'package:analyzer/src/generated/element.dart';
3 import 'package:analyzer/src/generated/scanner.dart'; 3 import 'package:analyzer/src/generated/scanner.dart';
4 import 'package:analyzer/src/generated/utilities_dart.dart'; 4 import 'package:analyzer/src/generated/utilities_dart.dart';
5 5
6 int _computeArgIndex(AstNode containingNode, Object entity) { 6 int _computeArgIndex(AstNode containingNode, Object entity) {
7 var argList = containingNode; 7 var argList = containingNode;
8 if (argList is ArgumentList) { 8 if (argList is ArgumentList) {
9 NodeList<Expression> args = argList.arguments; 9 NodeList<Expression> args = argList.arguments;
10 for (int index = 0; index < args.length; ++index) { 10 for (int index = 0; index < args.length; ++index) {
(...skipping 336 matching lines...) Expand 10 before | Expand all | Expand 10 after
347 if (param.parameterKind == ParameterKind.NAMED) { 347 if (param.parameterKind == ParameterKind.NAMED) {
348 // TODO(danrubel) handle named parameters 348 // TODO(danrubel) handle named parameters
349 return false; 349 return false;
350 } else { 350 } else {
351 return paramType is FunctionType || paramType is FunctionTypeAlias; 351 return paramType is FunctionType || paramType is FunctionTypeAlias;
352 } 352 }
353 } 353 }
354 return false; 354 return false;
355 } 355 }
356 } 356 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698