Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issue 134683007: IDL compiler: sync Python to r166680 (Closed)

Created:
6 years, 10 months ago by Nils Barth (inactive)
Modified:
6 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive, kouhei (in TOK)
Visibility:
Public.

Description

IDL compiler: sync Python to r166680 Python side to: Rename [GarbageCollected] to [WillBeGarbageCollected] https://codereview.chromium.org/140663011 BUG=239771 R=haraken NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166810

Patch Set 1 #

Patch Set 2 : Order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -540 lines) Patch
M Source/bindings/scripts/compute_dependencies.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/unstable/code_generator_v8.py View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/bindings/scripts/unstable/v8_interface.py View 3 chunks +8 lines, -7 lines 0 comments Download
M Source/bindings/scripts/unstable/v8_types.py View 1 3 chunks +13 lines, -13 lines 0 comments Download
M Source/bindings/templates/interface.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/interface_base.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
D Source/bindings/tests/idls/TestInterfaceGarbageCollected.idl View 1 chunk +0 lines, -37 lines 0 comments Download
A + Source/bindings/tests/idls/TestInterfaceWillBeGarbageCollected.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/idls/TestObjectPython.idl View 1 chunk +1 line, -1 line 0 comments Download
D Source/bindings/tests/results/V8TestInterfaceGarbageCollected.h View 1 chunk +0 lines, -161 lines 0 comments Download
D Source/bindings/tests/results/V8TestInterfaceGarbageCollected.cpp View 1 chunk +0 lines, -230 lines 0 comments Download
A + Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.h View 3 chunks +29 lines, -29 lines 0 comments Download
A + Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp View 7 chunks +39 lines, -39 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.cpp View 4 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nils Barth (inactive)
6 years, 10 months ago (2014-02-10 06:55:09 UTC) #1
haraken
LGTM
6 years, 10 months ago (2014-02-10 06:56:54 UTC) #2
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 10 months ago (2014-02-10 08:10:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/134683007/30001
6 years, 10 months ago (2014-02-10 08:10:55 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-10 08:11:13 UTC) #5
Message was sent while issue was closed.
Change committed as 166810

Powered by Google App Engine
This is Rietveld 408576698