Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: Source/bindings/scripts/unstable/v8_interface.py

Issue 134683007: IDL compiler: sync Python to r166680 (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Order Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/unstable/code_generator_v8.py ('k') | Source/bindings/scripts/unstable/v8_types.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/unstable/v8_interface.py
diff --git a/Source/bindings/scripts/unstable/v8_interface.py b/Source/bindings/scripts/unstable/v8_interface.py
index 97330a7d9143c03e75340caaf42fe6d474f0cf77..e75a97b8dec7a78d8dee13bd3935a786f9a04839 100644
--- a/Source/bindings/scripts/unstable/v8_interface.py
+++ b/Source/bindings/scripts/unstable/v8_interface.py
@@ -88,9 +88,6 @@ def generate_interface(interface):
if is_check_security:
includes.add('bindings/v8/BindingSecurity.h')
- # [GarbageCollected]
- is_garbage_collected = 'GarbageCollected' in extended_attributes
-
# [MeasureAs]
is_measure_as = 'MeasureAs' in extended_attributes
if is_measure_as:
@@ -119,6 +116,9 @@ def generate_interface(interface):
for special_wrap_interface in special_wrap_for:
v8_types.add_includes_for_type(special_wrap_interface)
+ # [WillBeGarbageCollected]
+ is_will_be_garbage_collected = 'WillBeGarbageCollected' in extended_attributes
+
template_contents = {
'conditional_string': conditional_string(interface), # [Conditional]
'cpp_class': cpp_name(interface),
@@ -138,14 +138,15 @@ def generate_interface(interface):
'is_document': is_document,
'is_event_target': inherits_interface(interface.name, 'EventTarget'),
'is_exception': interface.is_exception,
- 'is_garbage_collected': is_garbage_collected,
+ 'is_will_be_garbage_collected': is_will_be_garbage_collected,
'is_node': inherits_interface(interface.name, 'Node'),
'measure_as': v8_utilities.measure_as(interface), # [MeasureAs]
'parent_interface': parent_interface,
- 'pass_ref_ptr': 'PassRefPtrWillBeRawPtr' if is_garbage_collected else
- 'PassRefPtr',
+ 'pass_ref_ptr': 'PassRefPtrWillBeRawPtr'
+ if is_will_be_garbage_collected else 'PassRefPtr',
'reachable_node_function': reachable_node_function,
- 'ref_ptr': 'RefPtrWillBeRawPtr' if is_garbage_collected else 'RefPtr',
+ 'ref_ptr': 'RefPtrWillBeRawPtr'
+ if is_will_be_garbage_collected else 'RefPtr',
'runtime_enabled_function': runtime_enabled_function_name(interface), # [RuntimeEnabled]
'set_wrapper_reference_to_list': set_wrapper_reference_to_list,
'special_wrap_for': special_wrap_for,
« no previous file with comments | « Source/bindings/scripts/unstable/code_generator_v8.py ('k') | Source/bindings/scripts/unstable/v8_types.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698