Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issue 140663011: Rename [GarbageCollected] to [WillBeGarbageCollected] (Closed)

Created:
6 years, 10 months ago by haraken
Modified:
6 years, 10 months ago
CC:
blink-reviews, kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Rename [GarbageCollected] to [WillBeGarbageCollected] We need different IDL attributes for transition types and real types in oilpan. We will use [WillBeGarbageCollected] for transition types and [GarbageCollected] for real types (which will be implemented in the near future). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166680

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M Source/bindings/IDLExtendedAttributes.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/code_generator_v8.pm View 1 6 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/tests/idls/TestInterfaceGarbageCollected.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encoding/TextDecoder.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encoding/TextEncoder.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/gamepad/Gamepad.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/gamepad/GamepadList.idl View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
haraken
PTAL
6 years, 10 months ago (2014-02-06 06:38:00 UTC) #1
Mads Ager (chromium)
LGTM
6 years, 10 months ago (2014-02-06 06:48:20 UTC) #2
haraken
On 2014/02/06 06:48:20, Mads Ager (chromium) wrote: > LGTM Will land after landing https://codereview.chromium.org/156453002/. The ...
6 years, 10 months ago (2014-02-06 06:49:34 UTC) #3
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 10 months ago (2014-02-07 00:36:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/140663011/1
6 years, 10 months ago (2014-02-07 00:37:13 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-07 00:37:17 UTC) #6
commit-bot: I haz the power
Failed to apply patch for Source/modules/gamepad/GamepadList.idl: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-07 00:37:18 UTC) #7
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 10 months ago (2014-02-07 02:30:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/140663011/100001
6 years, 10 months ago (2014-02-07 02:30:53 UTC) #9
commit-bot: I haz the power
Change committed as 166680
6 years, 10 months ago (2014-02-07 05:27:39 UTC) #10
Nils Barth (inactive)
6 years, 10 months ago (2014-02-10 06:55:28 UTC) #11
Message was sent while issue was closed.
Python side at:
IDL compiler: sync Python to r166680
https://codereview.chromium.org/134683007/

Powered by Google App Engine
This is Rietveld 408576698