Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1346813002: Disallow Object.observe calls on access-checked objects (Closed)

Created:
5 years, 3 months ago by adamk
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disallow Object.observe calls on access-checked objects We already disallowed observing the global proxy; now we also disallow any observation of access-checked objects (regardless of whether the access check would succeed or fail, since there's not a good way to tell the embedder what kind of access is being requested). Also disallow Object.getNotifier for the same reasons. BUG=chromium:531891 LOG=y Committed: https://crrev.com/21bd4564538b43dec9ff8c70d43c77a4696e4cfb Cr-Commit-Position: refs/heads/master@{#30774}

Patch Set 1 #

Patch Set 2 : Add new error message and tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -1 line) Patch
M src/messages.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/object-observe.js View 1 2 chunks +4 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M test/cctest/test-object-observe.cc View 1 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jochen (gone - plz use gerrit)
we should go with this.
5 years, 3 months ago (2015-09-16 07:03:48 UTC) #2
adamk
The error message is a little wonky: there's nothing in ECMAScript (or really, in HTML) ...
5 years, 3 months ago (2015-09-16 19:28:03 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 3 months ago (2015-09-16 20:05:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346813002/20001
5 years, 3 months ago (2015-09-16 20:51:20 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-16 21:19:27 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-16 21:19:43 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/21bd4564538b43dec9ff8c70d43c77a4696e4cfb
Cr-Commit-Position: refs/heads/master@{#30774}

Powered by Google App Engine
This is Rietveld 408576698