Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Side by Side Diff: src/runtime/runtime-object.cc

Issue 1346813002: Disallow Object.observe calls on access-checked objects (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add new error message and tests Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/runtime/runtime.h ('k') | test/cctest/test-object-observe.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/bootstrapper.h" 8 #include "src/bootstrapper.h"
9 #include "src/debug/debug.h" 9 #include "src/debug/debug.h"
10 #include "src/isolate-inl.h" 10 #include "src/isolate-inl.h"
(...skipping 1533 matching lines...) Expand 10 before | Expand all | Expand 10 after
1544 1544
1545 // ES6 section 7.4.7 CreateIterResultObject ( value, done ) 1545 // ES6 section 7.4.7 CreateIterResultObject ( value, done )
1546 RUNTIME_FUNCTION(Runtime_CreateIterResultObject) { 1546 RUNTIME_FUNCTION(Runtime_CreateIterResultObject) {
1547 HandleScope scope(isolate); 1547 HandleScope scope(isolate);
1548 DCHECK_EQ(2, args.length()); 1548 DCHECK_EQ(2, args.length());
1549 CONVERT_ARG_HANDLE_CHECKED(Object, value, 0); 1549 CONVERT_ARG_HANDLE_CHECKED(Object, value, 0);
1550 CONVERT_ARG_HANDLE_CHECKED(Object, done, 1); 1550 CONVERT_ARG_HANDLE_CHECKED(Object, done, 1);
1551 return *isolate->factory()->NewJSIteratorResult(value, done); 1551 return *isolate->factory()->NewJSIteratorResult(value, done);
1552 } 1552 }
1553 1553
1554
1555 RUNTIME_FUNCTION(Runtime_IsAccessCheckNeeded) {
1556 SealHandleScope shs(isolate);
1557 DCHECK_EQ(1, args.length());
1558 CONVERT_ARG_CHECKED(Object, object, 0);
1559 return isolate->heap()->ToBoolean(object->IsAccessCheckNeeded());
1560 }
1561
1562
1554 } // namespace internal 1563 } // namespace internal
1555 } // namespace v8 1564 } // namespace v8
OLDNEW
« no previous file with comments | « src/runtime/runtime.h ('k') | test/cctest/test-object-observe.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698