Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Side by Side Diff: src/messages.h

Issue 1346813002: Disallow Object.observe calls on access-checked objects (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add new error message and tests Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/object-observe.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // The infrastructure used for (localized) message reporting in V8. 5 // The infrastructure used for (localized) message reporting in V8.
6 // 6 //
7 // Note: there's a big unresolved issue about ownership of the data 7 // Note: there's a big unresolved issue about ownership of the data
8 // structures used by this framework. 8 // structures used by this framework.
9 9
10 #ifndef V8_MESSAGES_H_ 10 #ifndef V8_MESSAGES_H_
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 T(ObjectGetterExpectingFunction, \ 153 T(ObjectGetterExpectingFunction, \
154 "Object.prototype.__defineGetter__: Expecting function") \ 154 "Object.prototype.__defineGetter__: Expecting function") \
155 T(ObjectGetterCallable, "Getter must be a function: %") \ 155 T(ObjectGetterCallable, "Getter must be a function: %") \
156 T(ObjectNotExtensible, "Can't add property %, object is not extensible") \ 156 T(ObjectNotExtensible, "Can't add property %, object is not extensible") \
157 T(ObjectSetterExpectingFunction, \ 157 T(ObjectSetterExpectingFunction, \
158 "Object.prototype.__defineSetter__: Expecting function") \ 158 "Object.prototype.__defineSetter__: Expecting function") \
159 T(ObjectSetterCallable, "Setter must be a function: %") \ 159 T(ObjectSetterCallable, "Setter must be a function: %") \
160 T(ObserveCallbackFrozen, \ 160 T(ObserveCallbackFrozen, \
161 "Object.observe cannot deliver to a frozen function object") \ 161 "Object.observe cannot deliver to a frozen function object") \
162 T(ObserveGlobalProxy, "% cannot be called on the global proxy object") \ 162 T(ObserveGlobalProxy, "% cannot be called on the global proxy object") \
163 T(ObserveAccessChecked, "% cannot be called on access-checked objects") \
163 T(ObserveInvalidAccept, \ 164 T(ObserveInvalidAccept, \
164 "Third argument to Object.observe must be an array of strings.") \ 165 "Third argument to Object.observe must be an array of strings.") \
165 T(ObserveNonFunction, "Object.% cannot deliver to non-function") \ 166 T(ObserveNonFunction, "Object.% cannot deliver to non-function") \
166 T(ObserveNonObject, "Object.% cannot % non-object") \ 167 T(ObserveNonObject, "Object.% cannot % non-object") \
167 T(ObserveNotifyNonNotifier, "notify called on non-notifier object") \ 168 T(ObserveNotifyNonNotifier, "notify called on non-notifier object") \
168 T(ObservePerformNonFunction, "Cannot perform non-function") \ 169 T(ObservePerformNonFunction, "Cannot perform non-function") \
169 T(ObservePerformNonString, "Invalid non-string changeType") \ 170 T(ObservePerformNonString, "Invalid non-string changeType") \
170 T(ObserveTypeNonString, \ 171 T(ObserveTypeNonString, \
171 "Invalid changeRecord with non-string 'type' property") \ 172 "Invalid changeRecord with non-string 'type' property") \
172 T(OrdinaryFunctionCalledAsConstructor, \ 173 T(OrdinaryFunctionCalledAsConstructor, \
(...skipping 313 matching lines...) Expand 10 before | Expand all | Expand 10 after
486 487
487 static MUST_USE_RESULT MaybeHandle<String> GetStringifiedProperty( 488 static MUST_USE_RESULT MaybeHandle<String> GetStringifiedProperty(
488 Isolate* isolate, LookupIterator* property_lookup, 489 Isolate* isolate, LookupIterator* property_lookup,
489 Handle<String> default_value); 490 Handle<String> default_value);
490 491
491 List<Handle<JSObject> > visited_; 492 List<Handle<JSObject> > visited_;
492 }; 493 };
493 } } // namespace v8::internal 494 } } // namespace v8::internal
494 495
495 #endif // V8_MESSAGES_H_ 496 #endif // V8_MESSAGES_H_
OLDNEW
« no previous file with comments | « no previous file | src/object-observe.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698