Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1346713002: move SkBitmapProvider to its own file (Closed)

Created:
5 years, 3 months ago by reed1
Modified:
5 years, 3 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

move SkBitmapProvider to its own file BUG=skia: Committed: https://skia.googlesource.com/skia/+/013e9e3bb0495ab0b5aff011429a6ac983464d34

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : fix spelling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -106 lines) Patch
M gyp/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkBitmapController.h View 1 chunk +1 line, -29 lines 0 comments Download
M src/core/SkBitmapController.cpp View 2 chunks +1 line, -71 lines 0 comments Download
M src/core/SkBitmapProcShader.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 4 chunks +5 lines, -4 lines 0 comments Download
M src/core/SkBitmapProcState.h View 1 chunk +2 lines, -0 lines 0 comments Download
A src/core/SkBitmapProvider.h View 1 2 1 chunk +44 lines, -0 lines 0 comments Download
A src/core/SkBitmapProvider.cpp View 1 chunk +79 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
reed1
ptal
5 years, 3 months ago (2015-09-15 21:22:26 UTC) #2
reed1
5 years, 3 months ago (2015-09-15 21:28:48 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346713002/1
5 years, 3 months ago (2015-09-15 21:28:51 UTC) #5
f(malita)
lgtm https://codereview.chromium.org/1346713002/diff/1/src/core/SkBitmapProvider.h File src/core/SkBitmapProvider.h (right): https://codereview.chromium.org/1346713002/diff/1/src/core/SkBitmapProvider.h#newcode35 src/core/SkBitmapProvider.h:35: // Only call this if you're sure you ...
5 years, 3 months ago (2015-09-15 21:29:45 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-15 21:34:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346713002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346713002/40001
5 years, 3 months ago (2015-09-15 21:40:41 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 21:46:30 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/013e9e3bb0495ab0b5aff011429a6ac983464d34

Powered by Google App Engine
This is Rietveld 408576698