Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 134643030: Prevent frame from being destroyed in middle of notification. (Closed)

Created:
6 years, 10 months ago by mharanczyk
Modified:
6 years, 9 months ago
Reviewers:
jamesr, nasko, dcheng, eseidel
CC:
blink-reviews, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Prevent frame from being destroyed in middle of notification. Extension injected scripts might trigger frame deletion during handling of its dispatchDidFinishDocumentLoad() function. BUG=328342

Patch Set 1 #

Patch Set 2 : Added protector to another place that can cause frame deletion. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/web/FrameLoaderClientImpl.cpp View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mharanczyk
6 years, 10 months ago (2014-02-07 13:30:59 UTC) #1
dcheng
+eseidel for the actual review. Here are some of my thoughts: This is kind of ...
6 years, 10 months ago (2014-02-14 20:38:30 UTC) #2
mharanczyk
6 years, 10 months ago (2014-02-25 10:36:43 UTC) #3
Added similar protector to documentElementAvailable().

Powered by Google App Engine
This is Rietveld 408576698