Source/web/FrameLoaderClientImpl.cpp - Issue 134643030: Prevent frame from being destroyed in middle of notification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/FrameLoaderClientImpl.cpp

Issue 134643030: Prevent frame from being destroyed in middle of notification. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added protector to another place that can cause frame deletion. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/FrameLoaderClientImpl.cpp

diff --git a/Source/web/FrameLoaderClientImpl.cpp b/Source/web/FrameLoaderClientImpl.cpp

index 4a787c608af060e3e188bc76e6bbdd3cd407a8d1..a278218cb436b6e6d9e30b79f4e6eb871e1ed128 100644

--- a/Source/web/FrameLoaderClientImpl.cpp

+++ b/Source/web/FrameLoaderClientImpl.cpp

@@ -127,6 +127,7 @@ void FrameLoaderClientImpl::dispatchDidClearWindowObjectInWorld(DOMWrapperWorld*

void FrameLoaderClientImpl::documentElementAvailable()

{

+ RefPtr<WebFrameImpl> protector(m_webFrame);

if (m_webFrame->client())

m_webFrame->client()->didCreateDocumentElement(m_webFrame);

}

@@ -303,6 +304,7 @@ void FrameLoaderClientImpl::dispatchDidFinishLoading(DocumentLoader* loader,

void FrameLoaderClientImpl::dispatchDidFinishDocumentLoad()

{

+ RefPtr<WebFrameImpl> protector(m_webFrame);

if (m_webFrame->client())

m_webFrame->client()->didFinishDocumentLoad(m_webFrame);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »