Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1346383004: EDK: Remove MOJO_SYSTEM_IMPL_EXPORT, system_impl_export.h, etc. (Closed)

Created:
5 years, 3 months ago by viettrungluu
Modified:
5 years, 3 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Remove MOJO_SYSTEM_IMPL_EXPORT, system_impl_export.h, etc. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/535e5d9de7412a78b0a2aa299f14c172273f9736

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -339 lines) Patch
M mojo/edk/embedder/BUILD.gn View 3 chunks +1 line, -8 lines 0 comments Download
M mojo/edk/embedder/embedder.h View 9 chunks +38 lines, -45 lines 0 comments Download
M mojo/edk/embedder/master_process_delegate.h View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/edk/embedder/platform_channel_pair.h View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/edk/embedder/platform_channel_utils_posix.h View 4 chunks +18 lines, -19 lines 0 comments Download
M mojo/edk/embedder/platform_handle.h View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/edk/embedder/platform_handle_utils.h View 2 chunks +2 lines, -5 lines 0 comments Download
M mojo/edk/embedder/platform_handle_vector.h View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/edk/embedder/platform_shared_buffer.h View 3 chunks +2 lines, -3 lines 0 comments Download
M mojo/edk/embedder/platform_support.h View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/edk/embedder/process_delegate.h View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/edk/embedder/process_type.h View 2 chunks +1 line, -5 lines 0 comments Download
M mojo/edk/embedder/scoped_platform_handle.h View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/edk/embedder/simple_platform_shared_buffer.h View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/edk/embedder/simple_platform_support.h View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/edk/embedder/slave_process_delegate.h View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/edk/embedder/test_embedder.h View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/edk/system/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M mojo/edk/system/async_waiter.h View 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/edk/system/awakable.h View 1 chunk +9 lines, -8 lines 0 comments Download
M mojo/edk/system/awakable_list.h View 2 chunks +8 lines, -9 lines 0 comments Download
M mojo/edk/system/channel.h View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/edk/system/channel_endpoint.h View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/edk/system/channel_endpoint_client.h View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/edk/system/channel_endpoint_id.h View 5 chunks +5 lines, -7 lines 0 comments Download
M mojo/edk/system/channel_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/configuration.h View 1 chunk +3 lines, -6 lines 0 comments Download
M mojo/edk/system/connection_manager.h View 3 chunks +3 lines, -5 lines 0 comments Download
M mojo/edk/system/connection_manager_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/system/core.h View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/edk/system/data_pipe.h View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.h View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/edk/system/data_pipe_impl.h View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.h View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/edk/system/dispatcher.h View 5 chunks +4 lines, -8 lines 0 comments Download
M mojo/edk/system/endpoint_relayer.h View 3 chunks +2 lines, -4 lines 0 comments Download
M mojo/edk/system/handle_signals_state.h View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/edk/system/handle_table.h View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/edk/system/incoming_endpoint.h View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/edk/system/ipc_support.h View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/edk/system/local_data_pipe_impl.h View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/edk/system/local_message_pipe_endpoint.h View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/edk/system/mapping_table.h View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/edk/system/master_connection_manager.h View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/edk/system/master_connection_manager.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/edk/system/memory.h View 2 chunks +3 lines, -6 lines 0 comments Download
M mojo/edk/system/memory.cc View 2 chunks +13 lines, -34 lines 0 comments Download
M mojo/edk/system/message_in_transit.h View 4 chunks +6 lines, -9 lines 0 comments Download
M mojo/edk/system/message_in_transit_queue.h View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/edk/system/message_pipe.h View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.h View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/edk/system/message_pipe_endpoint.h View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/edk/system/mutex.h View 3 chunks +2 lines, -3 lines 0 comments Download
M mojo/edk/system/options_validation.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/system/platform_handle_dispatcher.h View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/edk/system/proxy_message_pipe_endpoint.h View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/edk/system/raw_channel.h View 5 chunks +4 lines, -5 lines 0 comments Download
M mojo/edk/system/remote_consumer_data_pipe_impl.h View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/edk/system/remote_producer_data_pipe_impl.h View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher.h View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/edk/system/simple_dispatcher.h View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/edk/system/slave_connection_manager.h View 2 chunks +2 lines, -4 lines 0 comments Download
D mojo/edk/system/system_impl_export.h View 1 chunk +0 lines, -29 lines 0 comments Download
M mojo/edk/system/transport_data.h View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/edk/system/unique_identifier.h View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/edk/system/waiter.h View 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/edk/util/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
5 years, 3 months ago (2015-09-18 17:57:11 UTC) #1
jamesr
rslgtm
5 years, 3 months ago (2015-09-18 17:59:02 UTC) #2
jamesr
On 2015/09/18 at 17:59:02, jamesr wrote: > rslgtm rs *space* lgtm
5 years, 3 months ago (2015-09-18 17:59:13 UTC) #3
viettrungluu
5 years, 3 months ago (2015-09-18 18:12:55 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
535e5d9de7412a78b0a2aa299f14c172273f9736 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698