Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: mojo/edk/system/raw_channel.h

Issue 1346383004: EDK: Remove MOJO_SYSTEM_IMPL_EXPORT, system_impl_export.h, etc. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/system/proxy_message_pipe_endpoint.h ('k') | mojo/edk/system/remote_consumer_data_pipe_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/raw_channel.h
diff --git a/mojo/edk/system/raw_channel.h b/mojo/edk/system/raw_channel.h
index cc66fcb2dbd457cfb4e22b98485191f9b48cd03d..6a783955514d4fa30560c5ce5d5eebd68733c112 100644
--- a/mojo/edk/system/raw_channel.h
+++ b/mojo/edk/system/raw_channel.h
@@ -14,7 +14,6 @@
#include "mojo/edk/system/message_in_transit.h"
#include "mojo/edk/system/message_in_transit_queue.h"
#include "mojo/edk/system/mutex.h"
-#include "mojo/edk/system/system_impl_export.h"
#include "mojo/edk/system/thread_annotations.h"
#include "mojo/public/cpp/system/macros.h"
@@ -40,7 +39,7 @@ namespace system {
// With the exception of |WriteMessage()| and |IsWriteBufferEmpty()|, this class
// is thread-unsafe (and in general its methods should only be used on the I/O
// thread, i.e., the thread on which |Init()| is called).
-class MOJO_SYSTEM_IMPL_EXPORT RawChannel {
+class RawChannel {
public:
// This object may be destroyed on any thread (if |Init()| was called, after
// |Shutdown()| was called).
@@ -48,7 +47,7 @@ class MOJO_SYSTEM_IMPL_EXPORT RawChannel {
// The |Delegate| is only accessed on the same thread as the message loop
// (passed in on creation).
- class MOJO_SYSTEM_IMPL_EXPORT Delegate {
+ class Delegate {
public:
enum Error {
// Failed read due to raw channel shutdown (e.g., on the other side).
@@ -127,7 +126,7 @@ class MOJO_SYSTEM_IMPL_EXPORT RawChannel {
IO_PENDING
};
- class MOJO_SYSTEM_IMPL_EXPORT ReadBuffer {
+ class ReadBuffer {
public:
ReadBuffer();
~ReadBuffer();
@@ -147,7 +146,7 @@ class MOJO_SYSTEM_IMPL_EXPORT RawChannel {
MOJO_DISALLOW_COPY_AND_ASSIGN(ReadBuffer);
};
- class MOJO_SYSTEM_IMPL_EXPORT WriteBuffer {
+ class WriteBuffer {
public:
struct Buffer {
const char* addr;
« no previous file with comments | « mojo/edk/system/proxy_message_pipe_endpoint.h ('k') | mojo/edk/system/remote_consumer_data_pipe_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698