Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1314)

Unified Diff: mojo/edk/system/dispatcher.h

Issue 1346383004: EDK: Remove MOJO_SYSTEM_IMPL_EXPORT, system_impl_export.h, etc. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/system/data_pipe_producer_dispatcher.h ('k') | mojo/edk/system/endpoint_relayer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/dispatcher.h
diff --git a/mojo/edk/system/dispatcher.h b/mojo/edk/system/dispatcher.h
index 4a85915cbaf81c42a0c1ff355babf694bcd98ae5..4b0c558a248e264d6d899c2959be63c062c6042a 100644
--- a/mojo/edk/system/dispatcher.h
+++ b/mojo/edk/system/dispatcher.h
@@ -17,7 +17,6 @@
#include "mojo/edk/system/handle_signals_state.h"
#include "mojo/edk/system/memory.h"
#include "mojo/edk/system/mutex.h"
-#include "mojo/edk/system/system_impl_export.h"
#include "mojo/public/c/system/buffer.h"
#include "mojo/public/c/system/data_pipe.h"
#include "mojo/public/c/system/message_pipe.h"
@@ -47,8 +46,7 @@ using DispatcherVector = std::vector<scoped_refptr<Dispatcher>>;
namespace test {
// Test helper. We need to declare it here so we can friend it.
-MOJO_SYSTEM_IMPL_EXPORT DispatcherTransport
-DispatcherTryStartTransport(Dispatcher* dispatcher);
+DispatcherTransport DispatcherTryStartTransport(Dispatcher* dispatcher);
} // namespace test
@@ -57,8 +55,7 @@ DispatcherTryStartTransport(Dispatcher* dispatcher);
// object is thread-safe, with its state being protected by a single mutex
// |mutex_|, which is also made available to implementation subclasses (via the
// |mutex()| method).
-class MOJO_SYSTEM_IMPL_EXPORT Dispatcher
- : public base::RefCountedThreadSafe<Dispatcher> {
+class Dispatcher : public base::RefCountedThreadSafe<Dispatcher> {
public:
enum class Type {
UNKNOWN = 0,
@@ -390,7 +387,7 @@ class MOJO_SYSTEM_IMPL_EXPORT Dispatcher
//
// Note: This class is deliberately "thin" -- no more expensive than a
// |Dispatcher*|.
-class MOJO_SYSTEM_IMPL_EXPORT DispatcherTransport {
+class DispatcherTransport {
public:
DispatcherTransport() : dispatcher_(nullptr) {}
@@ -423,8 +420,7 @@ class MOJO_SYSTEM_IMPL_EXPORT DispatcherTransport {
};
// So logging macros and |DCHECK_EQ()|, etc. work.
-MOJO_SYSTEM_IMPL_EXPORT inline std::ostream& operator<<(std::ostream& out,
- Dispatcher::Type type) {
+inline std::ostream& operator<<(std::ostream& out, Dispatcher::Type type) {
return out << static_cast<int>(type);
}
« no previous file with comments | « mojo/edk/system/data_pipe_producer_dispatcher.h ('k') | mojo/edk/system/endpoint_relayer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698