Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 1346173004: Run tests that do not have any compile targets if source files change (Closed)

Created:
5 years, 3 months ago by bpastene
Modified:
5 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Run tests that do not have any compile targets if source files change This change makes tryjobs run tests that don't have any compile targets (check_deps, check_perm, etc) if there are source file changes. This fixes the problem that changes that don't impact linux can break check_deps since linux trybots are the only ones that run the check_* tests. Adopted from: https://codereview.chromium.org/1287723002 Which was adopted from: https://codereview.chromium.org/963263002 BUG=462308 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296802

Patch Set 1 #

Patch Set 2 : Rebase expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+440 lines, -37 lines) Patch
M scripts/slave/recipes/chromium_trybot.py View 1 4 chunks +63 lines, -35 lines 0 comments Download
A + scripts/slave/recipes/chromium_trybot.expected/analyze_runs_nothing_with_no_source_file_changes.json View 2 chunks +3 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_android_coverage_analyze.json View 1 1 chunk +374 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
bpastene
5 years, 3 months ago (2015-09-16 21:03:27 UTC) #2
jam
lgtm, thanks
5 years, 3 months ago (2015-09-17 14:44:49 UTC) #3
Paweł Hajdan Jr.
LGTM For some context, see also earlier https://codereview.chromium.org/907393002 .
5 years, 3 months ago (2015-09-17 15:55:53 UTC) #4
bpastene
About to commit this. I'll keep my eye on the tree and see what effect ...
5 years, 3 months ago (2015-09-21 23:16:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346173004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346173004/20001
5 years, 3 months ago (2015-09-21 23:39:28 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 23:43:49 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296802

Powered by Google App Engine
This is Rietveld 408576698