Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 907393002: Don't always run the script tests if there are no compile targets. (Closed)

Created:
5 years, 10 months ago by jam
Modified:
5 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Don't always run the script tests if there are no compile targets. This reverts r292542, since it had unintended consequences of increasing no-op linux try runs by 10 minutes. Almost all changes that would affect DEPS/licenses etc would involve DEPS/code changes. So we will watch the tree and look for cases where we wanted to run the check* steps to see how we can do this in a smarter way. BUG=454408 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294014

Patch Set 1 #

Messages

Total messages: 6 (2 generated)
jam
5 years, 10 months ago (2015-02-10 16:00:31 UTC) #2
sky
LGTM
5 years, 10 months ago (2015-02-10 17:41:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/907393002/1
5 years, 10 months ago (2015-02-10 17:47:55 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 17:50:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294014

Powered by Google App Engine
This is Rietveld 408576698