Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 963263002: Run scripts which don't have any compile targets if any source files change. (Closed)

Created:
5 years, 9 months ago by jam
Modified:
5 years, 4 months ago
Reviewers:
iannucci, luqui
CC:
chromium-reviews, cmp-cc_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Run scripts which don't have any compile targets if any source files change. This fixes the problem that checkdeps could be broken by changes that don't impact Linux, which is the only trybot that runs these tests. BUG=462308

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -15 lines) Patch
M scripts/slave/recipes/chromium_trybot.py View 2 chunks +27 lines, -15 lines 3 comments Download

Messages

Total messages: 7 (2 generated)
luqui
https://codereview.chromium.org/963263002/diff/1/scripts/slave/recipes/chromium_trybot.py File scripts/slave/recipes/chromium_trybot.py (right): https://codereview.chromium.org/963263002/diff/1/scripts/slave/recipes/chromium_trybot.py#newcode389 scripts/slave/recipes/chromium_trybot.py:389: return You could either add a test for it ...
5 years, 9 months ago (2015-03-02 23:21:53 UTC) #2
jam
https://codereview.chromium.org/963263002/diff/1/scripts/slave/recipes/chromium_trybot.py File scripts/slave/recipes/chromium_trybot.py (right): https://codereview.chromium.org/963263002/diff/1/scripts/slave/recipes/chromium_trybot.py#newcode389 scripts/slave/recipes/chromium_trybot.py:389: return On 2015/03/02 23:21:53, luqui wrote: > You could ...
5 years, 9 months ago (2015-03-04 15:16:42 UTC) #3
luqui
+iannucci in case I'm wrong. https://codereview.chromium.org/963263002/diff/1/scripts/slave/recipes/chromium_trybot.py File scripts/slave/recipes/chromium_trybot.py (right): https://codereview.chromium.org/963263002/diff/1/scripts/slave/recipes/chromium_trybot.py#newcode389 scripts/slave/recipes/chromium_trybot.py:389: return On 2015/03/04 15:16:41, ...
5 years, 9 months ago (2015-03-04 21:51:04 UTC) #5
luqui
I took this over at https://codereview.chromium.org/1287723002
5 years, 4 months ago (2015-08-11 22:32:04 UTC) #6
luqui
5 years, 4 months ago (2015-08-11 22:32:21 UTC) #7
Message was sent while issue was closed.
I took this over at https://codereview.chromium.org/1287723002

Powered by Google App Engine
This is Rietveld 408576698