Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 13459008: Support options page handling into ComponentExtensionManager. (Closed)

Created:
7 years, 8 months ago by Seigo Nonaka
Modified:
7 years, 8 months ago
Reviewers:
Nikita (slow), satorux1
CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Support options page handling into ComponentExtensionManager. Let me split UI change for chrome://settings/languages page. BUG=226922 TEST=ran chromeos_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194346

Patch Set 1 : #

Patch Set 2 : Remove GetOptionsPageURL. #

Patch Set 3 : nit: remove unused variable. #

Total comments: 8

Patch Set 4 : Addressing comments #

Total comments: 2

Patch Set 5 : Addressing a comment #

Patch Set 6 : Fix constructors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -27 lines) Patch
M chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc View 1 2 3 3 chunks +15 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_manager.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/cros_language_options_handler_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/ime/component_extension_ime_manager.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/ime/component_extension_ime_manager.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/ime/component_extension_ime_manager_unittest.cc View 1 3 chunks +2 lines, -18 lines 0 comments Download
M chromeos/ime/input_method_descriptor.h View 1 2 3 3 chunks +7 lines, -0 lines 0 comments Download
M chromeos/ime/input_method_descriptor.cc View 1 2 3 3 chunks +10 lines, -5 lines 0 comments Download
M chromeos/ime/input_method_descriptor_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/ime/input_method_whitelist.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Seigo Nonaka
7 years, 8 months ago (2013-04-05 07:07:16 UTC) #1
Seigo Nonaka
I'm sorry for changing my mind after sending code review, but please you stop review. ...
7 years, 8 months ago (2013-04-05 08:17:26 UTC) #2
Seigo Nonaka
Updated, please take a look. Thank you very much.
7 years, 8 months ago (2013-04-05 08:27:53 UTC) #3
Seigo Nonaka
ping?, just in case.
7 years, 8 months ago (2013-04-12 06:26:31 UTC) #4
Seigo Nonaka
I'm sorry for confusing you but please take a look?
7 years, 8 months ago (2013-04-15 03:54:26 UTC) #5
satorux1
https://codereview.chromium.org/13459008/diff/9002/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc File chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc (right): https://codereview.chromium.org/13459008/diff/9002/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc#newcode166 chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc:166: GURL gurl = extensions::Extension::GetResourceURL( gurl -> url https://codereview.chromium.org/13459008/diff/9002/chrome/browser/chromeos/input_method/input_method_manager_impl.cc File ...
7 years, 8 months ago (2013-04-15 04:16:08 UTC) #6
Seigo Nonaka
https://codereview.chromium.org/13459008/diff/9002/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc File chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc (right): https://codereview.chromium.org/13459008/diff/9002/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc#newcode166 chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc:166: GURL gurl = extensions::Extension::GetResourceURL( On 2013/04/15 04:16:08, satorux1 wrote: ...
7 years, 8 months ago (2013-04-15 04:25:52 UTC) #7
satorux1
LGTM with a nit https://codereview.chromium.org/13459008/diff/26001/chrome/browser/chromeos/input_method/mock_input_method_manager.cc File chrome/browser/chromeos/input_method/mock_input_method_manager.cc (right): https://codereview.chromium.org/13459008/diff/26001/chrome/browser/chromeos/input_method/mock_input_method_manager.cc#newcode121 chrome/browser/chromeos/input_method/mock_input_method_manager.cc:121: "", "", // <parameter name ...
7 years, 8 months ago (2013-04-15 04:47:48 UTC) #8
Seigo Nonaka
Thank you for your review! https://codereview.chromium.org/13459008/diff/26001/chrome/browser/chromeos/input_method/mock_input_method_manager.cc File chrome/browser/chromeos/input_method/mock_input_method_manager.cc (right): https://codereview.chromium.org/13459008/diff/26001/chrome/browser/chromeos/input_method/mock_input_method_manager.cc#newcode121 chrome/browser/chromeos/input_method/mock_input_method_manager.cc:121: "", On 2013/04/15 04:47:48, ...
7 years, 8 months ago (2013-04-15 04:52:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/13459008/35001
7 years, 8 months ago (2013-04-15 04:52:54 UTC) #10
Seigo Nonaka
Adding chrome/browser/ui/webui/options/chromeos/ owner. Hi Nikita, I changed an argument of constructor for InputMethodDescriptor, and it ...
7 years, 8 months ago (2013-04-15 05:05:51 UTC) #11
Nikita (slow)
lgtm
7 years, 8 months ago (2013-04-16 04:24:15 UTC) #12
Seigo Nonaka
Thank you for your review! I will submit with trybot check. Thank you!
7 years, 8 months ago (2013-04-16 07:26:47 UTC) #13
Seigo Nonaka
7 years, 8 months ago (2013-04-16 11:51:53 UTC) #14
Message was sent while issue was closed.
Committed patchset #6 manually as r194346 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698