Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Side by Side Diff: chromeos/ime/component_extension_ime_manager.h

Issue 13459008: Support options page handling into ComponentExtensionManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix constructors. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROMEOS_IME_COMPONENT_EXTENSION_IME_MANAGER_H_ 5 #ifndef CHROMEOS_IME_COMPONENT_EXTENSION_IME_MANAGER_H_
6 #define CHROMEOS_IME_COMPONENT_EXTENSION_IME_MANAGER_H_ 6 #define CHROMEOS_IME_COMPONENT_EXTENSION_IME_MANAGER_H_
7 7
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/observer_list.h" 10 #include "base/observer_list.h"
11 #include "chromeos/chromeos_export.h" 11 #include "chromeos/chromeos_export.h"
12 #include "chromeos/dbus/ibus/ibus_component.h" 12 #include "chromeos/dbus/ibus/ibus_component.h"
13 #include "chromeos/ime/input_method_descriptor.h" 13 #include "chromeos/ime/input_method_descriptor.h"
14 14
15 namespace chromeos { 15 namespace chromeos {
16 16
17 // Represents a component extension IME. 17 // Represents a component extension IME.
18 // TODO(nona): Use GURL for |option_page_url| instead of string.
18 struct CHROMEOS_EXPORT ComponentExtensionIME { 19 struct CHROMEOS_EXPORT ComponentExtensionIME {
19 ComponentExtensionIME(); 20 ComponentExtensionIME();
20 ~ComponentExtensionIME(); 21 ~ComponentExtensionIME();
21 std::string id; // extension id. 22 std::string id; // extension id.
22 std::string manifest; // the contents of manifest.json 23 std::string manifest; // the contents of manifest.json
23 std::string description; // description of extension. 24 std::string description; // description of extension.
25 std::string options_page_url; // We can't use GURL due to deps restriction.
24 base::FilePath path; 26 base::FilePath path;
25 std::vector<IBusComponent::EngineDescription> engines; 27 std::vector<IBusComponent::EngineDescription> engines;
26 }; 28 };
27 29
28 // Provides an interface to list/load/unload for component extension IME. 30 // Provides an interface to list/load/unload for component extension IME.
29 class CHROMEOS_EXPORT ComponentExtensionIMEManagerDelegate { 31 class CHROMEOS_EXPORT ComponentExtensionIMEManagerDelegate {
30 public: 32 public:
31 ComponentExtensionIMEManagerDelegate(); 33 ComponentExtensionIMEManagerDelegate();
32 virtual ~ComponentExtensionIMEManagerDelegate(); 34 virtual ~ComponentExtensionIMEManagerDelegate();
33 35
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 ObserverList<Observer> observers_; 133 ObserverList<Observer> observers_;
132 134
133 bool is_initialized_; 135 bool is_initialized_;
134 136
135 DISALLOW_COPY_AND_ASSIGN(ComponentExtensionIMEManager); 137 DISALLOW_COPY_AND_ASSIGN(ComponentExtensionIMEManager);
136 }; 138 };
137 139
138 } // namespace chromeos 140 } // namespace chromeos
139 141
140 #endif // CHROMEOS_IME_COMPONENT_EXTENSION_IME_MANAGER_H_ 142 #endif // CHROMEOS_IME_COMPONENT_EXTENSION_IME_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698