Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: chromeos/ime/input_method_descriptor.h

Issue 13459008: Support options page handling into ComponentExtensionManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix constructors. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/ime/component_extension_ime_manager_unittest.cc ('k') | chromeos/ime/input_method_descriptor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/ime/input_method_descriptor.h
diff --git a/chromeos/ime/input_method_descriptor.h b/chromeos/ime/input_method_descriptor.h
index 53a92a91db27f410a0e983ae5733c4782758ed14..3717411a2fc7badafb9340ba5dc15041caa304b8 100644
--- a/chromeos/ime/input_method_descriptor.h
+++ b/chromeos/ime/input_method_descriptor.h
@@ -24,6 +24,7 @@ class CHROMEOS_EXPORT InputMethodDescriptor {
const std::string& name,
const std::string& keyboard_layout,
const std::string& language_code,
+ const std::string& options_page_url,
bool third_party);
~InputMethodDescriptor();
@@ -37,6 +38,7 @@ class CHROMEOS_EXPORT InputMethodDescriptor {
const std::string& name() const { return name_; }
const std::string& keyboard_layout() const { return keyboard_layout_; }
const std::string& language_code() const { return language_code_; }
+ const std::string& options_page_url() const { return options_page_url_; }
bool third_party() const { return third_party_; }
// Returns the fallback input method descriptor (the very basic US
@@ -56,6 +58,11 @@ class CHROMEOS_EXPORT InputMethodDescriptor {
std::string keyboard_layout_;
// Language code like "ko", "ja", "en-US", and "zh-CN".
std::string language_code_;
+ // Options page URL e.g.
+ // "chrome-extension://ceaajjmckiakobniehbjpdcidfpohlin/options.html".
+ // We can't use GURL here due to dependency policy. This field is valid only
+ // for input method extension.
+ std::string options_page_url_;
// Indicates if this is a third party ime
bool third_party_;
};
« no previous file with comments | « chromeos/ime/component_extension_ime_manager_unittest.cc ('k') | chromeos/ime/input_method_descriptor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698